Skip to content

Parser: recover on missing union case field types#17455

Merged
psfinaki merged 2 commits into
dotnet:mainfrom
auduchinok:parser-unionCaseFieldType
Aug 2, 2024
Merged

Parser: recover on missing union case field types#17455
psfinaki merged 2 commits into
dotnet:mainfrom
auduchinok:parser-unionCaseFieldType

Conversation

@auduchinok

Copy link
Copy Markdown
Member

Continuation of #17452. Add recovery for unfinished union case fields:

type U =
    | A of i:
type U =
    | A of i: * int

@auduchinok auduchinok requested a review from a team as a code owner July 29, 2024 09:15
@auduchinok auduchinok force-pushed the parser-unionCaseFieldType branch from 43ecff6 to b288082 Compare July 29, 2024 09:15
@github-actions

github-actions Bot commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@auduchinok auduchinok changed the title Parser: recover on missing union case field type Parser: recover on missing union case field types Jul 29, 2024
Comment thread tests/service/data/SyntaxTree/Type/Union 05.fs.bsl Outdated
@auduchinok auduchinok force-pushed the parser-unionCaseFieldType branch from b288082 to 2f433d3 Compare August 1, 2024 13:18
@auduchinok auduchinok closed this Aug 1, 2024
@auduchinok auduchinok reopened this Aug 1, 2024
@psfinaki

psfinaki commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

/azp run

@psfinaki psfinaki enabled auto-merge (squash) August 1, 2024 16:58
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki

psfinaki commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants